-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of the Docker image #226
Comments
@oschuett would you agree? |
You could use the official CP2K containers: https://hub.docker.com/r/cp2k/cp2k/tags |
That doesn't solve the problem of testing/developing on ARM machines |
That's true. What I'm trying to say is that in my opinion it's not worth the effort. As for getting ride of the container, does this mean you would stop integration testing CP2K+AiiDA entirely on your side? |
No, absolutely not. I am only talking about removing the docker layer. I will run the tests directly on GitHub Runner. This will allow me to pull CP2K directly from the release page, since I am now sure that the architecture is x86. |
Currently, we rely on a Docker image for testing, but this approach is becoming increasingly problematic. While the initial goal was to provide a reproducible and portable environment, several challenges make this less effective in practice. Here are the issues that I encountered:
Architecture Compatibility:
Maintenance Burden:
Development Workflow Mismatch:
Coverage Reporting Issues:
Dependency on aiida-core Base Image:
Conclusion
Based on the above, I propose we stop using the container for testing the plugin to simplify our lives.
The text was updated successfully, but these errors were encountered: