Skip to content

Commit 5746ae8

Browse files
committed
find run_task not await coro crux
1 parent a078400 commit 5746ae8

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

src/aiida/brokers/rabbitmq/coordinator.py

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,19 @@ def add_broadcast_subscriber(
3333
sender_filters=None,
3434
identifier=None,
3535
):
36-
subscriber = kiwipy.BroadcastFilter(subscriber)
37-
38-
subject_filters = subject_filters or []
39-
sender_filters = sender_filters or []
40-
41-
for filter in subject_filters:
42-
subscriber.add_subject_filter(filter)
43-
for filter in sender_filters:
44-
subscriber.add_sender_filter(filter)
36+
# XXX: this change behavior of create_task when decide whether the broadcast is_filtered.
37+
# Need to understand the BroadcastFilter and make the improvement.
38+
# To manifest the issue of run_task not await, run twice 'test_launch.py::test_submit_wait'.
39+
40+
# subscriber = kiwipy.BroadcastFilter(subscriber)
41+
#
42+
# subject_filters = subject_filters or []
43+
# sender_filters = sender_filters or []
44+
#
45+
# for filter in subject_filters:
46+
# subscriber.add_subject_filter(filter)
47+
# for filter in sender_filters:
48+
# subscriber.add_sender_filter(filter)
4549

4650
subscriber = convert_to_comm(subscriber, self._loop)
4751
return self._comm.add_broadcast_subscriber(subscriber, identifier)

0 commit comments

Comments
 (0)