Skip to content

Commit 31a9259

Browse files
committed
Avoid RemoteData class spec in cleanup test
1 parent 02c1d75 commit 31a9259

1 file changed

Lines changed: 14 additions & 13 deletions

File tree

tests/orm/utils/test_remote.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
###########################################################################
99
"""Tests for remote utilities."""
1010

11-
from unittest.mock import Mock
11+
from unittest.mock import patch
1212

1313
import pytest
1414

@@ -39,23 +39,24 @@ def test_clean_mapping_remote_paths_skips_unconfigured_computer(tmp_path, monkey
3939
).store()
4040
configured.configure(user=user)
4141

42-
folder_unconfigured = Mock(spec=RemoteData)
43-
folder_configured = Mock(spec=RemoteData)
42+
folder_unconfigured = RemoteData(remote_path=str(tmp_path / 'unconfigured-folder'), computer=unconfigured)
43+
folder_configured = RemoteData(remote_path=str(tmp_path / 'configured-folder'), computer=configured)
4444

4545
warnings: list[str] = []
4646
monkeypatch.setattr(remote.echo, 'echo_warning', lambda message, **kwargs: warnings.append(message))
4747
monkeypatch.setattr(remote.echo, 'echo_success', lambda *args, **kwargs: None)
4848

49-
remote.clean_mapping_remote_paths(
50-
{
51-
unconfigured.uuid: [folder_unconfigured],
52-
configured.uuid: [folder_configured],
53-
},
54-
silent=True,
55-
)
56-
57-
folder_unconfigured._clean.assert_not_called()
58-
folder_configured._clean.assert_called_once()
49+
with patch.object(RemoteData, '_clean', autospec=True) as mock_clean:
50+
remote.clean_mapping_remote_paths(
51+
{
52+
unconfigured.uuid: [folder_unconfigured],
53+
configured.uuid: [folder_configured],
54+
},
55+
silent=True,
56+
)
57+
58+
mock_clean.assert_called_once()
59+
assert mock_clean.call_args.args[0] is folder_configured
5960

6061
assert warnings == [
6162
f'Skipping 1 remote folders on `{unconfigured.label}`: ' f'computer is not configured for user `{user.email}`'

0 commit comments

Comments
 (0)