Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint never connects to VS code #1029

Open
1 task done
nxfi777 opened this issue May 3, 2024 · 14 comments
Open
1 task done

Lint never connects to VS code #1029

nxfi777 opened this issue May 3, 2024 · 14 comments

Comments

@nxfi777
Copy link

nxfi777 commented May 3, 2024

What version of million are you using?

0.0.73

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Windows

What browser are you using?

Firefox, Chrome

Describe the Bug

I was originally using CRA, but the craco method does not resolve for the craco plugin object. I now am using the webpack method alongside webpack-bundle-analyzer. Here is my config:

// craco.config.js
const BundleAanlyzerPlugin = require("webpack-bundle-analyzer").BundleAnalyzerPlugin;
const MillionCompiler = require('@million/lint');

module.exports = function () {
  return {
    webpack: {
      configure: {
        entry: './src/index.js',
      },
      plugins: [new BundleAanlyzerPlugin({ analyzerMode: "server" }), MillionCompiler.webpack()],
    },
  };
};

The million lint plugin is installed, and eslint is working correctly. The issue is that no matter how long I wait, or how much I play around with the site, million lint never connects to VS code in the dev server environment. The site is responsive, and I am using block for some static elements.

Million lint

image

What's the expected result?

Million lint detects issues in my CSR SPA

Link to Minimal Reproducible Example

--

Participation

  • I am willing to submit a pull request for this issue.
Copy link

github-actions bot commented May 3, 2024

Thanks for opening this issue! A maintainer will review it soon.

@AhmedBaset
Copy link

I have the same issue, I intentionally wrote very bad code but it didn't report any of them. Then, I cloned the slow application referenced in the announcement and played around the app and it didn't detect any issue.

For context, I don't see the "Connecting to Visual Studio Code" like the OP.

@sannajammeh
Copy link

Same issue here, it does not connect to VScode at all. Just shows the toolbar saying "connecting to vscode"

@roymrinmoy
Copy link

Facing the same issue here. Everything is same as the OP except I'm using Vite on mac.

@tobySolutions
Copy link
Contributor

Hello there @nxfi777, @AhmedBaset, @sannajammeh, @roymrinmoy we have actually fixed this issue in the upcoming release and you will no longer experience this; apologies for the not so great first encounter.

@karthikmallireddy
Copy link

It's still not connecting.

@AhmedBaset
Copy link

It's still not connecting.

Have you updated to 1.0.0-rc.1?

@karthikmallireddy
Copy link

Yes but it's keep saying start dev server in VS Code.

@Stanzilla
Copy link

POST http://undefined:42423/ingest?z=1 net::ERR_NAME_NOT_RESOLVED

@RishabhTayal
Copy link

having same issue

@ImLunaHey
Copy link

please stop replying with "same issue" if you dont have anything extra to add.

ive updated to 1.0.0-rc.1 and im using the webpack provider. still having issues.

@tobySolutions can you confirm which version this is meant to be fixed in?

@ImLunaHey
Copy link

guessing this is related? ive tried the onboarding a few times now and every time the callback page just shows a blank page. i dont get redirected to a vscode:// url or anything.

Screenshot 2024-05-22 at 7 57 22 PM

@jessedubbink
Copy link

I have opened a question regarding the same issue this morning in the Discord server. Including the reproduction steps.

Hi, I'm excited to use Million Lint but I can't seem to login.

I've installed Million and MillionLint and installed the vscode extension. After which it guided me to authenticate using google or github. But after signing in with either of the options, it did not actually sign me in.

I'm still stuck on https://beta-million-lint.vercel.app/auth/callback in the browser.

I've tried using Arc and firefox but neither seem to solve the issue.

Steps:

  1. I get the prompt to sign in, I click Allow.
  2. I get the vscode confirmation to open the link to an external website, I click Open.
  3. I sign in using GitHub
  4. I get the authorization screen for Clerk, I click Authorize.
  5. It tells me I'm redirected, after which I'm redirected to a blank page with the auth/callback url from above.

The plugin in vscode stays unauthenticated.

@ImLunaHey
Copy link

update. i managed to get an account made and the extension is now authenticated. i had to go through the login process a LOT of times though, finally on the last time it seems to have worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants