Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Million Lint silent mode if someone does not have the Million Lint VS Code extension installed #1015

Closed
1 task done
nickytonline opened this issue Apr 4, 2024 · 7 comments
Labels

Comments

@nickytonline
Copy link

Describe the feature

I started using Million Lint yesterday and plan to add it to our project, however, not everyone working on the project, external contributors or maybe even some core team members who aren't necessarily working in the React part of the project, might want to run the development environment without it.

At the moment, they receive this error message.

CleanShot 2024-04-04 at 07 40 33

It's pretty clear in what you need to do, but again, someone who might be doing a styling fix or something else completely unrelated to potential performance improvements might find this as a friction point to contribute to the project.

I have workarounds that I could do, like an environment variable, but a silent error option to suppress the above would be ideal.

Happy to contribute towards this if this is something the team considers.

Additional information

  • Would you be willing to help implement this feature?
Copy link

github-actions bot commented Apr 4, 2024

Thanks for opening this issue! A maintainer will review it soon.

@tobySolutions
Copy link
Contributor

Hmm, thank you very much for raising this @nickytonline! Really appreciate it. At the moment there isn't any in the compiler at the moment. I will inform the team of this so they can make decisions regarding this.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Apr 20, 2024
@nickytonline
Copy link
Author

For the time being @tobySolutions, so we can use it in the project, I've gone with the environment variable approach I've mentioned in this issue. See open-sauced/app#3108

@github-actions github-actions bot removed the Stale label Apr 23, 2024
@tobySolutions
Copy link
Contributor

Hmm, thank you very much @nickytonline; I reported the issue and they are currently working on it. We have a release coming very soon later this month or the next and these should have been handled by then. Thank you very much!

@nickytonline
Copy link
Author

Thanks for the update!

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants