Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Million lint currently doesn't support monorepo #1005

Open
1 task done
DannyAziz opened this issue Mar 20, 2024 · 14 comments
Open
1 task done

Million lint currently doesn't support monorepo #1005

DannyAziz opened this issue Mar 20, 2024 · 14 comments

Comments

@DannyAziz
Copy link

Describe the feature

Wasn't able to get million to work from inside a monorepo but noticed the GET call that was being made in my browser returned the following[{"cwd":"/Users/USER/Development/MONOREPOROOT,"port":52921,"version":0}] whereas the app I was testing is inside a nested folder

Opened up the specific app from a new Cursor window and everything works perfectly

Someway to provide a path to the extension or to the MillionLint call in my config file would be great!

Additional information

  • Would you be willing to help implement this feature?
Copy link

Thanks for opening this issue! A maintainer will review it soon.

@tobySolutions
Copy link
Contributor

Hmm, thank you for reporting this. That is definitely weird. I'll inform the team to look into this.

@guipace
Copy link

guipace commented Mar 22, 2024

+1 on looking forward to it working with monorepos

@A-Shleifman
Copy link

Million is failing to connect when the root folder of the monorepo is opened in VSCode, however, there is no issue when opening the subproject folder directly.

Copy link

github-actions bot commented Apr 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Apr 8, 2024
@ChiefORZ
Copy link

ChiefORZ commented Apr 8, 2024

well its still not working github bot -.-

@github-actions github-actions bot removed the Stale label Apr 9, 2024
@tejas-hosamani
Copy link

tejas-hosamani commented Apr 11, 2024

When I run npx @million/lint@latest

Need to install the following packages:
  @million/lint@latest
Ok to proceed? (y)
┌  ⚡ Million Lint
│
◇  Yarn detected.
│
◒  Installing @million/lint with Yarn.│
■  Warnings during installation. Command failed: yarn add @million/lint@latest --ignore-workspace-root-check
│
◇
│
◇  Would you like to continue anyway?
│  No
│
└  Setup failed.

I get this when I try installing million in monorepo. Should this be installed in a specific app/project within monorepo?


Edit: Is it okay to install it manually with yard add -D @million/lint?

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Apr 27, 2024
@cyrus-za
Copy link

still doesnt work

@github-actions github-actions bot removed the Stale label Apr 29, 2024
@tobySolutions
Copy link
Contributor

still doesnt work

Hey there @cyrus-za, this is being fixed by the team and will be available in the next release. Please bear with us.

@tejas-hosamani
Copy link

@tobySolutions , when is the next release?
And what's the release cycle?
I don't see a release after March 9th, so.

@cyrus-za
Copy link

cyrus-za commented May 3, 2024

still doesnt work

Hey there @cyrus-za, this is being fixed by the team and will be available in the next release. Please bear with us.

No problem. I was merely replying to the bot that wants to close the stale issue so I gave it new life :)

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label May 19, 2024
@ChiefORZ
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

still not released and fixed

@github-actions github-actions bot removed the Stale label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants