Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Million Lint Ignoring custom webpack config #1003

Open
1 task
LPSebi opened this issue Mar 19, 2024 · 10 comments
Open
1 task

Million Lint Ignoring custom webpack config #1003

LPSebi opened this issue Mar 19, 2024 · 10 comments
Labels
million-lint This issue is related to Million Lint Stale

Comments

@LPSebi
Copy link

LPSebi commented Mar 19, 2024

What version of million are you using?

3.0.6

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Windows

What browser are you using?

Chrome, Firefox

Describe the Bug

Million Lint v0.0.73

image
When updating the webpack config in next.config.mjs it will not get applied when using million lint and will therefore show this error:
image

What's the expected result?

Apply the webpack config changes correctly

Link to Minimal Reproducible Example

Participation

  • I am willing to submit a pull request for this issue.
Copy link

Thanks for opening this issue! A maintainer will review it soon.

@lxsmnsyc lxsmnsyc added the million-lint This issue is related to Million Lint label Mar 20, 2024
@tobySolutions
Copy link
Contributor

Thank you for this, the team is actively working on this.

@Archimagus
Copy link

Just to add to this. It also doesn't seem to support loaders correctly.

  webpack: (config) => {
    config.module.rules.push({
      test: /\.(frag|vert|glsl)$/,
      type: 'asset/source',
    });
    return config;
  },
./src/materials/shaders/CustomDiffuse.frag
Module parse failed: Unexpected token (1:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> #ifdef USE_MAP
|   vec4 col1 = texture2D( map, vMapUv );
|   if(diffuseColor.a < 0.5) 

It works correctly without million.

Copy link

github-actions bot commented Apr 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Apr 6, 2024
@Sliov
Copy link

Sliov commented Apr 9, 2024

Same issue here

@github-actions github-actions bot removed the Stale label Apr 10, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Apr 25, 2024
@Archimagus
Copy link

Archimagus commented Apr 29, 2024

No word on support for this?

@github-actions github-actions bot removed the Stale label Apr 30, 2024
@tobySolutions
Copy link
Contributor

No word on support for this?

Hey there @Archimagus, this is being worked on by the team and will be available in the next release. I'll confirm with the team to be sure as well.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label May 19, 2024
@ImLunaHey
Copy link

bad bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
million-lint This issue is related to Million Lint Stale
Projects
None yet
Development

No branches or pull requests

6 participants