Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server side validation of RiveScript code #1

Open
kirsle opened this issue Jul 19, 2016 · 0 comments
Open

Server side validation of RiveScript code #1

kirsle opened this issue Jul 19, 2016 · 0 comments

Comments

@kirsle
Copy link
Member

kirsle commented Jul 19, 2016

The front-end enforces that RiveScript code must "compile" (not raise syntax errors) before being allowed to be shared with others, but the back-end doesn't do this. The back-end only makes sure that the source size is less than 64KB.

With the code refactor in rivescript-python#30 the server should be able to safely utilize the rivescript.parser module to parse the code to check for syntax errors while avoiding all the potential issues of accepting/processing arbitrary RiveScript code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant