-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can’t use --height
in fzf options on Windows
#385
Comments
Yeah this is a bit tricky. I suspect we pass the same stderr that we get in both Go and Bash based implementations of kubectx. I'm inclined to think this is gonna be hard to troubleshoot and fix on our side. I recommend WSL. 🤷🏼 |
I understand. It seems like a difficult thing to address, if that’s even possible. I prefer to use Windows, not WSL, so I’ll look for an alternative for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All this works fine under Linux (ignoring that I didn’t choose an option):
But on Windows:
This is because, in fzf, it’s assumed that the stream always supports whatever
LightRenderer
is under Linux, but the logic is more complicated under Windows. My Go is very limited and I’m out of my depth with this terminal stuff. Is there any way for kubectx to convince fzf that the STDERR it passes supports whatever it needs to run?(The reason why I need --height is that otherwise it clears the screen every time fzf runs, unlike under Linux where it renders independently and then returns to the shell session.)
The text was updated successfully, but these errors were encountered: