Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摝 NEW: SOP Italics Version #8

Open
Oluwasetemi opened this issue Jul 24, 2018 · 8 comments
Open

馃摝 NEW: SOP Italics Version #8

Oluwasetemi opened this issue Jul 24, 2018 · 8 comments
Assignees

Comments

@Oluwasetemi
Copy link

Oluwasetemi commented Jul 24, 2018

I thought we could extend this to all type of fonts giving them the feel of italics by creating a scope for things like comments, keywords and setting the fontStyle to italic.

This will make italic available to any font used with SOP

@ahmadawais
Copy link
Owner

@Oluwasetemi welcome here. Can you mention which entities do NOT render as italic that are intended in the theme to be italic and are so with Operator Mono? Coz. anything that's meant to be italic is set to do so in the syntax settings.

Give an example or two so that I can investigate.

@Oluwasetemi
Copy link
Author

italics

Here is my own italics
I tried the default theme on my friend's system then i saw it didn't have some italics but I think Operator mono come with some italics default!

@Oluwasetemi
Copy link
Author

Looking through this repo i am learning a lot especially with generating the CHANGELOG.md automatically using clTemplate.hbs is so cool.

@ahmadawais
Copy link
Owner

ahmadawais commented Aug 16, 2018

@Oluwasetemi glad you're learning from my work. Looking into the italics.

@ahmadawais
Copy link
Owner

@Oluwasetemi Can you send me the italics data above in the screenshot as text. I can't create it again. Easier to copy paste.

Here're the italics that are already in there in 馃 Shades of Purple:

{
			"name": "[ITALLICS] All the awesome itallics live here.",
			"scope": [
				"modifier",
				"this",
				"comment",
				"storage.modifier.js",
				"entity.other.attribute-name.js",
				"entity.other.attribute-name.html",
				"punctuation.definition.comment",
				"text.html.basic entity.other",
				"entity.other.attribute-name.tsx",
				"entity.other.attribute-name.jsx",
				"markup.quote.markdown meta.paragraph.markdown",
				"markup.italic.markdown",
				"text.jade entity.other.attribute-name.tag",
				"keyword.control.from.js",
				"entity.other.attribute-name.tag.pug"
			],
			"settings": {
				"fontStyle": "italic"
			}
		}

@Oluwasetemi
Copy link
Author

 {
  "scope": [
    "comment",
    "keyword.control",
    "keyword.operator.new",
    "keyword.operator.assignment",
    "keyword.operator.arithmetic",
    "keyword.other",
    "storage.modifier",
    "storage.type",
    "support.class",
    "support.constant",
    "support.function",
    "support.other",
    "entity.name.class",
    "entity.name.function",
    "entity.name.method",
    "entity.name.section",
    "entity.name.selector",
    "entity.name.type",
    "entity.other",
    "entity.other.attribute-name",
    "entity.other.inherited-class"
  ],
  "settings": {
    "fontStyle": "italic"
  }
}

@ahmadawais ahmadawais self-assigned this Sep 6, 2018
@ahmadawais ahmadawais changed the title Font Italics is only enabled with user using operator-mono. 馃摝 NEW: SOP Italics Version Oct 5, 2018
@RDhar
Copy link

RDhar commented May 3, 2019

Just wondering about this, is it meant to be a variation of SOP that places more of an emphasis on increased syntax italicisation? If so, I'm all aboard the idea!

Coming from Palenight, it has in-built a dedicated variation of the theme which extends support for Operator Mono. Thereby, more code is italicised than is usually expected from a theme, hence it is an option that the user can choose to enable.

As usual, a picture speaks a thousand words, so you can see below the following scope is italicised: HTML tag property values, CSS selector names, JS var/return/if/for/function and the likes.

image

@ahmadawais
Copy link
Owner

@RDhar Oh yes, I haven't had a chance to work on the italic version in the last 8 months but there are already some experiments here.

Ultimately I want five versions of 馃 Shades of Purple

  • 馃 Shades of Purple Default
  • 馃 Shades of Purple Dull/Dimm/Mutted
  • 馃 Shades of Purple High Contrast
  • 馃 Shades of Purple Light
  • 馃 Shades of Purple Italic

For all that we need to build tooling like webpack would compile all these themes from one source automagically. That's a lot of work but you can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants