DEV: added csv export to states #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this works, but the command you've provided doesn't seem to. If |
pokimochi
reviewed
Jul 25, 2020
Comment on lines
+53
to
+67
|
|
||
| const csvWriter = createCsvWriter({ | ||
| path: 'output/chart.csv', | ||
| header: [ | ||
| {id: 'state', title: 'State'}, | ||
| {id: 'cases', title: 'Cases'}, | ||
| {id: 'todayCases', title: 'Cases (today)'}, | ||
| {id: 'deaths', title: 'Deaths'}, | ||
| {id: 'todayDeaths', title: 'Deaths (today)'}, | ||
| {id: 'active', title: 'Active'}, | ||
| ] | ||
| }); | ||
|
|
||
| csvWriter.writeRecords(allStates); | ||
|
|
There was a problem hiding this comment.
corona states throws an error when the output folder does not exist. I suggest creating the directory if it doesn't exist before writing the records.
There was a problem hiding this comment.
Hi, I want to add code to remove this bug. How do I do this? Should I clone, make amends and then do a PR ? or something else ?
There was a problem hiding this comment.
i suggest you can clone and add a new commit to this pr with the fix, thanks
|
I solved that problem using directory checking process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added CSV export option along with the chart display for additional visualization option.
Instructions:
The csv file generation is configured with the states feature. The output is a csv file with the data stored in output folder.
Run command:
corona --s statesFixes #98