Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for in-frame stops even if a gene is incomplete #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomasbruna
Copy link

@tomasbruna tomasbruna commented May 2, 2023

Currently, the mapped genes are scanned for in-frame stop codons only if they are complete. Similarly, if a gene is 5' incomplete, the 3' end is not checked.

This pull request changes the behavior to check and report the presence of start, stop, and in-frame stops independently.

This is useful because an incomplete mapping which preserves the ORF is much less concerning than an incomplete mapping with in-frame stops. There is no way to distinguish the two in the current output.

@tomasbruna
Copy link
Author

There is also a more concerning issue with the current implementation. If the translation goes out of frame due to a frameshift in the target sequence (introducing lots of in-frame stops), Liftoff may report this as a "missing stop" even if the alignment actually ends with a stop codon (the existing stop is translated out of the frame and thus appears to be missing).

The fix also takes care of a scenario like this by adding the in-frame stop flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant