Skip to content

Commit c23d0f4

Browse files
committed
doc: Fix a dependency version pinning comment
- Removed the mention of an old specific grpc version in the pinning comment.
1 parent 77f916f commit c23d0f4

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/dependabot.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ updates:
2121
- dependency-name: "org.springframework.boot:*"
2222
update-types: [ "version-update:semver-major" ] # Bump this after we bump to Java 17, which v3 requires (and the current v2 will be supported until November 2023: https://spring.io/blog/2022/05/24/preparing-for-spring-boot-3-0)
2323
- dependency-name: "com.google.protobuf:protoc"
24-
update-types: [ "version-update:semver-major" ] # We need to stay with protobuf-java & protoc 3.25.x as the latest grpc 1.62.2 still depends on protobuf-java & protoc 3.25.x https://github.com/grpc/grpc-java/issues/11015
24+
update-types: [ "version-update:semver-major" ] # We need to stay with protobuf-java & protoc 3.25.x as the latest grpc still depends on protobuf-java & protoc 3.25.x https://github.com/grpc/grpc-java/issues/11015
2525
- dependency-name: "com.google.protobuf:protobuf-java"
26-
update-types: [ "version-update:semver-major" ] # We need to stay with protobuf-java & protoc 3.25.x as the latest grpc 1.62.2 still depends on protobuf-java & protoc 3.25.x https://github.com/grpc/grpc-java/issues/11015
26+
update-types: [ "version-update:semver-major" ] # We need to stay with protobuf-java & protoc 3.25.x as the latest grpc still depends on protobuf-java & protoc 3.25.x https://github.com/grpc/grpc-java/issues/11015
2727

2828

2929
- package-ecosystem: "github-actions"

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ buildscript {
2525
snakeyamlVersion = '2.3'
2626
grpcVersion = '1.66.0'
2727
// We need to stay with protobuf-java & protoc 3.25.x as the latest
28-
// grpc 1.62.2 still depends on protobuf-java & protoc 3.25.x. Once we
28+
// grpc still depends on protobuf-java & protoc 3.25.x. Once we
2929
// bump grpc to version that depnds on protobuf-java & protoc to 4.x.x,
3030
// it is likely that we are going to get conflicts because we also have
3131
// direct dependency to protobuf 3.25.x. We will need to bump protobuf

0 commit comments

Comments
 (0)