Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should allow specification of Private or Public IPs #128

Open
jpSimkins opened this issue Nov 21, 2016 · 0 comments
Open

Should allow specification of Private or Public IPs #128

jpSimkins opened this issue Nov 21, 2016 · 0 comments

Comments

@jpSimkins
Copy link

jpSimkins commented Nov 21, 2016

I see this is adding aliases for both private and public IPs. This is redundant as only one will only be used (the first found). Should be an option to specify what is used on a per alias level.

This will force you to improve the alias system. So I also recommend you do it more as an associative array. The key is the host and then the value are the parameters. This would allow you to assign subdomains on a single host versus having to create one for each and every subdomain.

Something like this would be more useful IMHO

[
   'test.dev' : [
      'subdomains': ['www', 'account1', 'account2'],
      'route': 'private'
   ]
]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant