Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor high level constructor interface #141

Closed
radka-j opened this issue Jan 30, 2025 · 0 comments · Fixed by #143
Closed

Refactor high level constructor interface #141

radka-j opened this issue Jan 30, 2025 · 0 comments · Fixed by #143
Assignees

Comments

@radka-j
Copy link
Contributor

radka-j commented Jan 30, 2025

What is the current workflow and can this be improved?

Eventually we want to do inference over the a/b parameters, number of planktons etc. At the moment, this is only possible by creating a new constructor class. What we really want is to create the BGC abstract type with the appropriate emergent parameters and methods (with/without default values) and then create a function that returns a concrete instance given the high level, allometric parameters (including N and diameters).

@radka-j radka-j self-assigned this Jan 30, 2025
@radka-j radka-j changed the title Investigate letting users update allometric parameters easily Refactor high level constructor interface Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant