Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset sidebar scroll top to 0 when navigating between sections of the site #398

Open
ngokevin opened this issue Oct 31, 2016 · 2 comments
Open

Comments

@ngokevin
Copy link
Member

When going from Blog -> Docs, the Sidebar should reset scroll state top to 0.

Can do this by keeping track of last section in localStorage and checking.

@cvan
Copy link
Contributor

cvan commented Nov 8, 2016

could do this with history.pushState and a popstate event listener and pjax-standalone (or similar)

@lainshiHenry
Copy link

As of testing today,
image

Navigating between Docs and Blog, the sidebar position does not change.
When you select Blog, then on the sidebar try to select Docs, as Docs is the first item in the list, you would scroll all the way up to select Docs.

As a test case:
image

  1. I did a partial scroll to reveal a part of Docs
  2. Clicked on the Docs link
  3. Sidebar position does not change.

Navigating between direct links (https://aframe.io/blog/) and (https://aframe.io/docs) does reset the sidebar position.

I know this issue is almost 8 years old, @ngokevin @dmarcos does this issue still need to be looked at?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants