fix package name in day 24

Author: ythirion

…e/day24/src/main/java/M/Instruction.java …src/main/java/submarine/Instruction.javaexercise/day24/src/main/java/M/Instruction.java renamed to exercise/day24/src/main/java/submarine/Instruction.java exercise/day24/src/main/java/M/Instruction.java renamed to exercise/day24/src/main/java/submarine/Instruction.java

@@ -1,4 +1,4 @@
-package M;
+package submarine;
 
 public record Instruction(String text, int x) {
     public static Instruction fromText(String text) {

…cise/day24/src/main/java/M/Position.java …24/src/main/java/submarine/Position.javaexercise/day24/src/main/java/M/Position.java renamed to exercise/day24/src/main/java/submarine/Position.java exercise/day24/src/main/java/M/Position.java renamed to exercise/day24/src/main/java/submarine/Position.java

@@ -1,4 +1,4 @@
-package M;
+package submarine;
 
 public record Position(int horizontal, int depth) {
     public Position changeDepth(int newDepth) {

…ise/day24/src/main/java/M/Submarine.java …4/src/main/java/submarine/Submarine.javaexercise/day24/src/main/java/M/Submarine.java renamed to exercise/day24/src/main/java/submarine/Submarine.java exercise/day24/src/main/java/M/Submarine.java renamed to exercise/day24/src/main/java/submarine/Submarine.java

@@ -1,4 +1,4 @@
-package M;
+package submarine;
 
 import java.util.List;
 

…ise/day24/src/test/java/M/FileUtils.java …4/src/test/java/submarine/FileUtils.javaexercise/day24/src/test/java/M/FileUtils.java renamed to exercise/day24/src/test/java/submarine/FileUtils.java exercise/day24/src/test/java/M/FileUtils.java renamed to exercise/day24/src/test/java/submarine/FileUtils.java

@@ -1,4 +1,4 @@
-package M;
+package submarine;
 
 import java.io.IOException;
 import java.net.URISyntaxException;

…ay24/src/test/java/M/SubmarineTests.java …/test/java/submarine/SubmarineTests.javaexercise/day24/src/test/java/M/SubmarineTests.java renamed to exercise/day24/src/test/java/submarine/SubmarineTests.java exercise/day24/src/test/java/M/SubmarineTests.java renamed to exercise/day24/src/test/java/submarine/SubmarineTests.java

@@ -1,4 +1,4 @@
-package M;
+package submarine;
 
 import org.junit.jupiter.api.Test;
 

solution/day23/src/main/java/org/craftedsw/tripservicekata/exception/CollaboratorCallException.java

@@ -1,25 +1,22 @@
 package org.craftedsw.tripservicekata.exception;
 
 public class CollaboratorCallException extends RuntimeException {
+    private static final long serialVersionUID = -4584041339906109902L;
 
-	private static final long serialVersionUID = -4584041339906109902L;
+    public CollaboratorCallException() {
+        super();
+    }
 
-	public CollaboratorCallException() {
-		super();
-	}
+    public CollaboratorCallException(String message,
+                                     Throwable cause) {
+        super(message, cause);
+    }
 
-	public CollaboratorCallException(String message,
-			Throwable cause) {
-		super(message, cause);
-	}
+    public CollaboratorCallException(String message) {
+        super(message);
+    }
 
-	public CollaboratorCallException(String message) {
-		super(message);
-	}
-
-	public CollaboratorCallException(Throwable cause) {
-		super(cause);
-	}
-
-	
+    public CollaboratorCallException(Throwable cause) {
+        super(cause);
+    }
 }

solution/day23/src/main/java/org/craftedsw/tripservicekata/exception/UserNotLoggedInException.java

@@ -1,7 +1,6 @@
 package org.craftedsw.tripservicekata.exception;
 
 public class UserNotLoggedInException extends RuntimeException {
+    private static final long serialVersionUID = 8959479918185637340L;
 
-	private static final long serialVersionUID = 8959479918185637340L;
-
-}
+}

solution/day23/src/main/java/org/craftedsw/tripservicekata/trip/TripService.java

@@ -36,7 +36,7 @@ private Try<Seq<Trip>> checkUser(User loggedUser,
                 : failure(new UserNotLoggedInException());
     }
 
-    protected Seq<Trip> findTripsByUser(User user) {
+    private Seq<Trip> findTripsByUser(User user) {
         return repository.findTripsByUser(user);
     }
 }

solution/day23/src/main/java/org/craftedsw/tripservicekata/user/UserSession.java

@@ -3,19 +3,17 @@
 import org.craftedsw.tripservicekata.exception.CollaboratorCallException;
 
 public class UserSession {
+    private static final UserSession userSession = new UserSession();
 
-	private static final UserSession userSession = new UserSession();
-	
-	private UserSession() {
-	}
-	
-	public static UserSession getInstance() {
-		return userSession;
-	}
+    private UserSession() {
+    }
 
-	public User getLoggedUser() {
-		throw new CollaboratorCallException(
-				"UserSession.getLoggedUser() should not be called in an unit test");
-	}
+    public static UserSession getInstance() {
+        return userSession;
+    }
 
-}
+    public User getLoggedUser() {
+        throw new CollaboratorCallException(
+                "UserSession.getLoggedUser() should not be called in an unit test");
+    }
+}

solution/day23/src/test/java/org/craftedsw/tripservicekata/trip/TripRepositoryShould.java

@@ -9,7 +9,7 @@
 import static org.junit.jupiter.api.DisplayNameGenerator.ReplaceUnderscores;
 
 @DisplayNameGeneration(ReplaceUnderscores.class)
-public class TripRepositoryShould {
+class TripRepositoryShould {
     private final TripRepository tripRepository = new TripRepository();
 
     @Test