Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --create-jre-image from temurin-build #3933

Open
sxa opened this issue Sep 3, 2024 · 0 comments
Open

Remove --create-jre-image from temurin-build #3933

sxa opened this issue Sep 3, 2024 · 0 comments
Labels
arm Issues that affect or relate to the ARM OS jenkins Issues that enhance or fix our jenkins server

Comments

@sxa
Copy link
Member

sxa commented Sep 3, 2024

Since we include the --create-jre-image in the pipeline configuration files, the line that sets it in make-adopt-build-farm.sh is obsolete, and the comment associated with it is not really accurate either. On that basis I would suggests we remove it from there, and stick with the parameter in the pipelines.

Noting that we could use this as an opportunity to review the guidelines in https://github.com/adoptium/temurin-build/blob/master/FAQ.md#how-do-i-change-the-parameters-such-as-configure-flags-for-a-jenkins-build about where to add parameters if necessary.

@github-actions github-actions bot added arm Issues that affect or relate to the ARM OS jenkins Issues that enhance or fix our jenkins server labels Sep 3, 2024
@sxa sxa removed jenkins Issues that enhance or fix our jenkins server arm Issues that affect or relate to the ARM OS labels Sep 3, 2024
@github-actions github-actions bot added arm Issues that affect or relate to the ARM OS jenkins Issues that enhance or fix our jenkins server labels Sep 3, 2024
@sxa sxa changed the title Remote --create-jre-image from temurin-build Remove --create-jre-image from temurin-build Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues that affect or relate to the ARM OS jenkins Issues that enhance or fix our jenkins server
Projects
Status: Todo
Development

No branches or pull requests

1 participant