Improving status propagation code in pipelines #759
Conversation
We don't seem to allow for the pipeline to have a null status, which the API tells us is possible when calling getResult(). I've patched this logic gap and added some better logging to aid future debugging. Signed-off-by: Adam Farley <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
|
Issue here: #750 Test run here: https://ci.adoptium.net/job/build-scripts/job/openjdk11-pipeline/2438/ |
|
The pipeline above didn't work because it was using the wrong branch, as the ci-jenkins-pipeline branch that the pipeline itself uses is hard-coded in the job config. I temporarily overrode the pipelines branch in the job config and launched this: https://ci.adoptium.net/job/build-scripts/job/openjdk11-pipeline/2440/ The end state of both builds in the pipeline was "unstable", and the pipeline status reflects this. Removing the WIP state of this PR, and we can worry about merging it after the release. |
adamfarley
changed the title
Pull request was converted to draft
|
/thaw |
github-actions
bot
dismissed
their stale review
Pull Request unblocked - code freeze is over.
Co-authored-by: Andrew Leonard <[email protected]>
Co-authored-by: Andrew Leonard <[email protected]>
We don't seem to allow for the pipeline to have a null status, which the API tells us is possible when calling getResult(). I've patched this logic gap and added some better logging to aid future debugging. Signed-off-by: Adam Farley <[email protected]>
We don't seem to allow for the pipeline to have a null status, which the API tells us is possible when calling getResult().
I've patched this logic gap and added some better logging to aid future debugging.