Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdk23+ update version GA tag check should be using updates repo #1127

Merged

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Oct 16, 2024

jdk23+ update version GA tag check should be using updates repo

if jdkBranch is jdk-NN.0.X then use "updates" repo...

Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@andrew-m-leonard
Copy link
Contributor Author

/merge

Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@steelhead31
Copy link
Contributor

/approve

@andrew-m-leonard andrew-m-leonard merged commit 277131e into adoptium:v2024.10.01 Oct 16, 2024
8 checks passed
andrew-m-leonard added a commit to andrew-m-leonard/ci-jenkins-pipelines that referenced this pull request Oct 16, 2024
…tium#1127)

* jdk-23.0.1 release jdkBranch GA tag check using wrong repo

Signed-off-by: Andrew Leonard <[email protected]>

* jdk-23.0.1 release jdkBranch GA tag check using wrong repo

Signed-off-by: Andrew Leonard <[email protected]>

---------

Signed-off-by: Andrew Leonard <[email protected]>
@gdams
Copy link
Member

gdams commented Oct 16, 2024

/approve

andrew-m-leonard added a commit that referenced this pull request Oct 16, 2024
… (#1128)

* jdk-23.0.1 release jdkBranch GA tag check using wrong repo



* jdk-23.0.1 release jdkBranch GA tag check using wrong repo



---------

Signed-off-by: Andrew Leonard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants