Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss the creation of a single job to launch the dryrun pipelines #1028

Open
adamfarley opened this issue May 8, 2024 · 0 comments
Open

Comments

@adamfarley
Copy link
Contributor

Summary

During the April 2024 General Retrospective, it was proposed that we discuss the creation of a single job to launch the pre-release dryrun pipelines.

Specifically to remove the possibility of someone accidentally adding an invalid "+7" to the dryrun version string (detailed below), though there are likely many other benefits also.

Original comment

Noting that on my initial attempt to set the dryrun tags I made it jdk-17.0.11+7-dryrun-ga (i.e. including the +7 build identifier. This will cause problems and such a tag will need to be deleted prior to running the pipelines or you'll get something like this from openjdk_pipeline.groovy:

[INFO] Resolved jdk-17.0.11-dryrun-ga to upstream build tag jdk-17.0.11+6jdk-17.0.11+6-dryrun-ga
[Pipeline] echo
[ERROR] scmReference does not match with any JDK branch in testenv.properties in aqa-tests release branch. Please update aqa-tests v1.0.1-release release branch. Set the current build result to FAILURE!

Also noting that if the pipeline does fail after being triggered, the workspace/tracking file on the jenkins worker node will need to be manually updated or you won't be able to re-trigger as the job uses that for its status and will not re-trigger the same underlying tag twice unless it's manually fixed.

EDIT: I'm not sure why but the jdk-17.0.11+6-dryrun-ga seemed to re-appear and caused the same issue when I did a second dry-run. Same happened for other releases I'd done it for. EDIT: It was because the jenkins workspace machine still had a cache of the old tag so we were pushing it on every update

Originally posted by @sxa in adoptium/temurin#28 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant