exclude JDK23+ and jdknext openj9 xmac testing on mac10 #5688
Conversation
buildenv/jenkins/openjdk_tests
Outdated
| LABEL += "&&!sw.os.mac.10" | ||
| // assume if JDK_VERSION is set to next, JDK_VERSION is 23+ | ||
| if (params.JDK_IMPL == "openj9" && PLATFORM == "x86-64_mac" && params.JDK_VERSION) { | ||
| if (params.JDK_VERSION.equalsIgnoreCase("next") || params.JDK_VERSION.toInteger() >= 23) { |
There was a problem hiding this comment.
I think this should be using isInteger() rather than make a special case for "next".
if (!params.JDK_VERSION.isInteger() || params.JDK_VERSION.toInteger() >= 23) {
|
The grinder states "With AUTO_DETECT=on, JDK_VERSION value is required only if SDK_RESOURCE=nightly/releases. Otherwise, please leave it empty." Setting it to next with AUTO_DETECT off won't work. |
Signed-off-by: Lan Xia <[email protected]>
|
Description The test pipeline cannot consume next, so it will try to get Java version and set it at a later stage. AUTO_DETECT has to be set when using JDK_VERSION=next. |
|
What does "JDK_VERSION=next" mean? Does it have special meaning, or is it just ignored and we could set any non-integer value? |
|
|
Signed-off-by: Lan Xia <[email protected]>
* exclude JDK23+ and jdknext openj9 xmac testing on mac10 (#5688) Signed-off-by: Lan Xia <[email protected]> * Support Semeru Artifactoriy SDK URL for releases (#5697) resolves: #5696 and automation/issues/82 Signed-off-by: Lan Xia <[email protected]> * Remove support for semeru-runtimes/api (#5700) related: #5696 and automation/issues/82 Signed-off-by: Lan Xia <[email protected]> --------- Signed-off-by: Lan Xia <[email protected]>
related: #5686 (comment)