Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect SHA shown for Red Hat marketplace binary #3221

Open
tellison opened this issue Nov 12, 2024 · 5 comments
Open

Incorrect SHA shown for Red Hat marketplace binary #3221

tellison opened this issue Nov 12, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@tellison
Copy link
Contributor

Describe the bug
The SHA value shown for the Red Hat build of OpenJDK is not correct on the Adoptium Marketplace website.

To Reproduce
Load the marketplace webpage, e.g.
https://adoptium.net/marketplace/?os=linux&package=jre&arch=x64

  1. Load the page then look at the Red Hat Checksum SHA256 value - it is blank.
  2. Look at another vendor's Checksum SHA and see the value.
  3. Look at the Red Hat SHA value in (1) again and it is the same as the value for vendor in (2).
  4. Look at another vendor's SHA value.
  5. Look at the Red Hat SHA value again and it is now the same as the vendor in step (4).

The Red Hat SHA value is just displayed as whatever was last viewed.

Expected behavior
The marketplace website should show the correct SHA - or display an appropriate message if it is unavailable.

Desktop (please complete the following information):
Believed to be on all.

Additional context
Red Hat data source is https://github.com/rh-openjdk/marketplace

@tellison tellison added the bug Something isn't working label Nov 12, 2024
@tellison
Copy link
Contributor Author

tellison commented Nov 12, 2024

"sha256sum" is not being returned from marketplace API call

https://marketplace-api.adoptium.net/v1/assets/feature_releases/redhat/21?architecture=x64&image_type=jdk&os=linux

compare to Adoptium data call

https://marketplace-api.adoptium.net/v1/assets/feature_releases/adoptium/21?architecture=x64&image_type=jdk&os=linux

Two issues here:

  1. Why is the API not returning the sha256sum field?
  2. The website should not use 'old' values from other displays when an sha256 is not provided.

@tellison
Copy link
Contributor Author

Cause of the first problem is
adoptium/marketplace-api.adoptium.net#542

Second problem for website code remains.

@xavierfacq xavierfacq self-assigned this Nov 20, 2024
@xavierfacq
Copy link
Member

I take care of the website problem to do not display the previous value if there is nothing

@tellison
Copy link
Contributor Author

Marketplace API fixed via adoptium/marketplace-api.adoptium.net#553

@tellison
Copy link
Contributor Author

Can consider showing the 'sha265sum' (typo) field value until the vendors update to the new schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants