Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEEP_REPORTDIR does not work as expected #156

Open
llxia opened this issue Mar 4, 2021 · 5 comments
Open

KEEP_REPORTDIR does not work as expected #156

llxia opened this issue Mar 4, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@llxia
Copy link
Contributor

llxia commented Mar 4, 2021

When KEEP_REPORTDIR is set to false, we should not capture any passed test artifacts. However, this does not work as expected. Please see the build link below:
https://ci.eclipse.org/openj9/job/Test_openjdk8_j9_extended.functional_s390x_linux_aot_Personal_testList_0/4/

It looks like all test artifacts are captured.

I think this is due to test pipeline uses boolean https://github.com/AdoptOpenJDK/openjdk-tests/blob/e55242930ee3bd56ceb2cbdcb898df130fbfc9c9/buildenv/jenkins/JenkinsfileBase#L78
https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/buildenv/jenkins/JenkinsfileBase#L264

and TKG uses string https://github.com/AdoptOpenJDK/TKG/blob/b7d19e42ab2c131d71ba037304b6efd8e07d5ad5/settings.mk#L195

@karianna karianna added the bug Something isn't working label Mar 4, 2021
@llxia
Copy link
Contributor Author

llxia commented Mar 4, 2021

@llxia
Copy link
Contributor Author

llxia commented Mar 4, 2021

@OscarQQ Could you help with this issue? Thanks

smlambert pushed a commit to adoptium/aqa-tests that referenced this issue Mar 10, 2021
@smlambert
Copy link
Contributor

Given adoptium/aqa-tests#2348 is now merged, can this be closed?

@smlambert
Copy link
Contributor

Indeed. I was looking through to tag good first issues, ones where there is a clear step by step description of the changes required. I will leave this open, but not tagged as 'good first issue' for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants