-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement logic to find Java version in JavaVersion.java #114
Labels
Comments
Hi! Trying on work on this task but I could not find any tests to verify the changes are correct. Any suggestions on how I should test my changes or should I open a PR directly for review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should remove the version check altogether and update the logic of figuring out various Java versions in JavaVersion.java to depend on Java system properties instead of parsing java -version output.
The text was updated successfully, but these errors were encountered: