Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cents not being overwriiten #44

Open
jrock2004 opened this issue Nov 9, 2017 · 4 comments
Open

Cents not being overwriiten #44

jrock2004 opened this issue Nov 9, 2017 · 4 comments
Labels

Comments

@jrock2004
Copy link
Contributor

jrock2004 commented Nov 9, 2017

So I am using your plugin and when I type the numbers everything is getting replaced. Then I use the arrow keys to move before the cents symbol, hit the period and the cursor moves in front of first cent number. Then I try to hit a number and nothing happens.

Here is a link to an Ember Twiddle with an example https://ember-twiddle.com/d7e72b96e9e48b66b4c16988d15a947e?openFiles=routes.application.js%2C

Update 1: It appears that bug was introduced in version 0.4.0-beta.2 as when I set it to beta.1, it works

@brandynbennett
Copy link
Collaborator

@jrock2004 are you still seeing this? Your twiddle is set to 0.4.0-beta.5 and it seems to be working?

@jrock2004
Copy link
Contributor Author

@brandynbennett I just tried it again with that link and it still does not work.

@brandynbennett
Copy link
Collaborator

You're right. It still does that. I think it may have something to do with the underlying library. A notable change from 0.4.0-beta.1 to beta.2 was a bump in the inputmask library. I made a completely new component one-way-number-mask that has a different architecture and the same bug is happening. Looking into it more

@brandynbennett
Copy link
Collaborator

So when I looked at this just now each number you type adds a number, doesn't replace it. So if you have already fill up the maximum decimal places, moving the cursor with the arrows won't let you add any more decimals. However if you haven't typed all the decimals yet it will insert them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants