Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider returning window from openTestWindow #1150

Open
jacobq opened this issue May 9, 2022 · 0 comments
Open

Consider returning window from openTestWindow #1150

jacobq opened this issue May 9, 2022 · 0 comments

Comments

@jacobq
Copy link
Collaborator

jacobq commented May 9, 2022

Not that I'd want to encourage anyone to use @electron/remote, but I still have code that uses it so need to do stuff like: require('@electron/remote/main').enable(someWindow.webContents);

In the case of an ember-electron app's tests, this means I can't use the default openTestWindow function in lib/test-support/index.js because it doesn't return a reference to the BrowserWindow it creates. It's not really a big deal in that it's not hard to work around, but if you'd be open to a PR that changes this I'd be willing to make one. (And it'd let me reduce some duplication on my side.)

See also:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant