Should renderProps.children be spread as a DOM attribute in ProgressBar?

[jbenning-ic]

While reviewing the ProgressBar implementation, I noticed the following line:

<div {...progressBarProps} {...renderProps} ref={ref} slot={props.slot || undefined}>

Wouldn’t spreading {...renderProps} also spread renderProps.children onto the

as an attribute?
If so, is this intentional? Or should children be destructured from renderProps and placed inside the div instead? Typically, children isn’t a valid DOM attribute and should be rendered as content within the element.

Reference:
ProgressBar.tsx#L76

[snowystinger]

Spreading children into there is fine, it'd overwritten by the actual JSX children since they come "later" (last) in the props