Skip to content

Commit b9b0995

Browse files
committed
prefer deprecated prop over context to make this a non-breaking change
1 parent 72cec38 commit b9b0995

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/@react-aria/overlays/src/Overlay.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export function Overlay(props: OverlayProps): ReactNode | null {
5757
let contextValue = useMemo(() => ({contain, setContain}), [contain, setContain]);
5858

5959
let {getContainer} = useUNSTABLE_PortalContext();
60-
if (getContainer) {
60+
if (!props.portalContainer && getContainer) {
6161
portalContainer = getContainer();
6262
}
6363

packages/@react-aria/overlays/src/useModal.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ export function OverlayContainer(props: OverlayContainerProps): React.ReactPorta
129129
let isSSR = useIsSSR();
130130
let {portalContainer = isSSR ? null : document.body, ...rest} = props;
131131
let {getContainer} = useUNSTABLE_PortalContext();
132-
if (getContainer) {
132+
if (!props.portalContainer && getContainer) {
133133
portalContainer = getContainer();
134134
}
135135

0 commit comments

Comments
 (0)