Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix share link #246

Merged
merged 2 commits into from
May 15, 2024
Merged

Fix share link #246

merged 2 commits into from
May 15, 2024

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented May 15, 2024

Description

Removed the & from the URL sanitization function.

Motivation

It was causing the share link to not be imported correctly.

Related Issue(s)

#242

To-do list

  • This pull request is ready to merge.

Copy link

changeset-bot bot commented May 15, 2024

⚠️ No Changeset found

Latest commit: c88e692

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GarthDB
Copy link
Member Author

GarthDB commented May 15, 2024

Run report for c88e6928

Total time: 21.4s | Comparison time: 19.8s | Estimated loss: 1.7s (7.8% slower)

Action Time Status Info
🟩 SyncWorkspace 0ms Passed
⬛️ SetupNodeTool(~20.11) 1.2s Skipped
🟩 InstallNodeDeps(~20.11) 8.8s Passed
🟩 SyncNodeProject(contrast-colors) 0.1ms Passed
🟩 SyncNodeProject(ui) 0.3ms Passed
🟩 RunTask(contrast-colors:test) 2.2s Passed
🟩 RunTask(ui:makeDistDir) 33ms Passed
🟩 RunTask(ui:copyCNAME) 17.8ms Passed
🟩 RunTask(ui:copyUIIcons) 56.1ms Passed
🟩 RunTask(ui:copyWorkflowIcons) 46.9ms Passed
🟩 RunTask(ui:buildSite) 9.2s Passed
Touched files
.moon/toolchain.yml
docs/ui/package.json
docs/ui/src/js/utils.js
package.json
pnpm-lock.yaml

@GarthDB GarthDB merged commit 98ac3d5 into main May 15, 2024
3 checks passed
@GarthDB GarthDB deleted the garthdb/fix-share-link branch May 15, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant