Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing removed from contrast-colors package #248

Open
NateBaldwinDesign opened this issue Sep 12, 2024 · 0 comments
Open

Testing removed from contrast-colors package #248

NateBaldwinDesign opened this issue Sep 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@NateBaldwinDesign
Copy link
Collaborator

NateBaldwinDesign commented Sep 12, 2024

Description

  • Test script and Jest have been removed from the contrast-colors package (removed in this pr).
  • README.md refers to running pnpm test for testing, yet it does not work as the test scripts have been removed
  • Result: unclear how to test and effectively know if any enhancements or bugs are going to break the Leonardo package.

Steps to reproduce

  1. Clone the repo

  2. In terminal, navigate to contrast-colors package

  3. Run pnpm test

  4. See error

  5. View the package.json for contrast-colors

  6. See there is no test script and Jest dependency has been removed

Expected behavior

Expect to use test-driven development to ensure stability of project when introducing any changes or enhancements

Screenshots

Leonardo package and version

Version 1.0.0

Environment

  • Browser(s) and OS(s):

Additional context

@NateBaldwinDesign NateBaldwinDesign added the bug Something isn't working label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant