Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage Firefly app url not printed in GitHub workflows #104

Open
sarahxxu opened this issue Sep 25, 2020 · 3 comments
Open

Stage Firefly app url not printed in GitHub workflows #104

sarahxxu opened this issue Sep 25, 2020 · 3 comments

Comments

@sarahxxu
Copy link

Expected Behaviour

We should print out the url to the deployed Firefly app when the GitHub workflow completes.

Actual Behaviour

Customer has deployed his app to stage through the OOTB github actions and monitored that the workflow in github finished successfully. But he's unable to see the url as the namespace is considered a github secret. (see screenshot for example)

image (10)

Reproduce Scenario (including but not limited to)

Use the Stage / Prod workflow to generate applications

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

@meryllblanchet
Copy link

Note: the namespace name is currently handled as a Github secret.

Question 1): would it be fine to not handle it as a secret?
Question 2): @sandeep-paliwal in that case, what alternatives would we have to pass it as a regular environment variable to the Github action?

@sandeep-paliwal
Copy link
Contributor

We can handle it as an env variable, which is set in .github/workflows/<filename>.yml files.
Here we can have two options

  1. Set this env variable in file when the app is generated (only for namespace), and remove step to add namespace as GH secret from documentation.
  2. Let users set it manually, update docs accordingly

WDYT?

@meryllblanchet
Copy link

Thanks @sandeep-paliwal ! I think it could be a mix of 1) set the variable upon app creation and 2) document where it is set and how this is working.

Let's first get @sarahxxu 's confirmation that we can handle the namespace name as a regular environment variable and not as a secret.

I'll then move the issue to the GH actions repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants