CFURLCreateStringByAddingPercentEscapes is deprecated – warning suppressed

[appsunited]

Due the fact that CFURLCreateStringByAddingPercentEscapes is deprecated since iOS 9.0 the method [NSString stringByAddingPercentEncodingWithAllowedCharacters:] should be used instead.

Also we are not sure whether it's a good idea to suppress the warning via:

pragma clang diagnostic ignored "-Wdeprecated-declarations"

[uerceg]

@appsunited Thanks for your suggestion and yes, we will remove suppressions in next updates, probably next one. Will keep you updated.

[fadyyecob]

I created a PR (#583) to use [self stringByAddingPercentEncodingWithAllowedCharacters: [NSCharacterSet URLQueryAllowedCharacterSet]] and remove the commented code. Imo using this function with URLQueryAllowedCharacterSet is the proper way to send a query string over an URLRequest

Please take a look and review @uerceg

Edit: updated my PR. It still uses URLQueryAllowedCharacterSet but subtracts the original characters "!*'\"();:@&=+$,/?%#[]% ", since those should also be encoded