Skip to content

Commit 87806b8

Browse files
uercegnonelse
authored andcommitted
refac: remove referrer from ADJDeeplink for now
1 parent 6190efe commit 87806b8

File tree

8 files changed

+2
-35
lines changed

8 files changed

+2
-35
lines changed

Adjust/ADJDeeplink.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212

1313
@property (nonatomic, copy, readonly, nonnull) NSURL *deeplink;
1414

15-
@property (nonatomic, copy, nullable) NSURL *referrer;
16-
1715
- (nullable ADJDeeplink *)initWithDeeplink:(nonnull NSURL *)deeplink;
1816

1917
@end

Adjust/Adjust.m

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -401,8 +401,7 @@ - (void)processDeeplink:(ADJDeeplink *)deeplink {
401401
[ADJUserDefaults cacheDeeplinkUrl:deeplink.deeplink];
402402
NSDate *clickTime = [NSDate date];
403403
if (![self checkActivityHandler]) {
404-
[ADJUserDefaults saveDeeplinkUrl:deeplink.deeplink
405-
referrerUrl:deeplink.referrer
404+
[ADJUserDefaults saveDeeplinkUrl:deeplink.deeplink
406405
clickTime:clickTime];
407406
return;
408407
}
@@ -421,7 +420,6 @@ - (void)processAndResolveDeeplink:(nonnull ADJDeeplink *)deeplink
421420
NSDate *clickTime = [NSDate date];
422421
if (![self checkActivityHandler]) {
423422
[ADJUserDefaults saveDeeplinkUrl:deeplink.deeplink
424-
referrerUrl:deeplink.referrer
425423
clickTime:clickTime];
426424
self.cachedResolvedDeeplinkBlock = completion;
427425
return;

Adjust/Internal/ADJActivityHandler.m

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,6 @@ - (void)processDeeplink:(ADJDeeplink *)deeplink withClickTime:(NSDate *)clickTim
401401
block:^(ADJActivityHandler * selfI) {
402402
[selfI processDeeplinkI:selfI
403403
url:deeplink.deeplink
404-
referrer:deeplink.referrer
405404
clickTime:clickTime];
406405
}];
407406
}
@@ -415,7 +414,6 @@ - (void)processAndResolveDeeplink:(ADJDeeplink * _Nullable)deeplink
415414
selfI.cachedDeeplinkResolutionCallback = completion;
416415
[selfI processDeeplinkI:selfI
417416
url:deeplink.deeplink
418-
referrer:deeplink.referrer
419417
clickTime:clickTime];
420418
}];
421419
}
@@ -1168,12 +1166,9 @@ - (void)processCachedDeeplinkI:(ADJActivityHandler *)selfI {
11681166
if (cachedDeeplinkClickTime == nil) {
11691167
return;
11701168
}
1171-
// referrer URL can be nil
1172-
NSURL *cachedDeeplinkReferrerUrl = [ADJUserDefaults getDeeplinkReferrerUrl];
11731169

11741170
[selfI processDeeplinkI:selfI
11751171
url:cachedDeeplinkUrl
1176-
referrer:cachedDeeplinkReferrerUrl
11771172
clickTime:cachedDeeplinkClickTime];
11781173
[ADJUserDefaults removeDeeplink];
11791174
}
@@ -1924,7 +1919,6 @@ - (void)checkStatusI:(ADJActivityHandler *)selfI
19241919

19251920
- (void)processDeeplinkI:(ADJActivityHandler *)selfI
19261921
url:(NSURL *)deeplink
1927-
referrer:(NSURL *)referrer
19281922
clickTime:(NSDate *)clickTime {
19291923
if (![selfI isEnabledI:selfI]) {
19301924
return;
@@ -1968,9 +1962,6 @@ - (void)processDeeplinkI:(ADJActivityHandler *)selfI
19681962
clickBuilder.attribution = deeplinkAttribution;
19691963
clickBuilder.clickTime = clickTime;
19701964
clickBuilder.deeplink = [deeplink absoluteString];
1971-
if (referrer != nil) {
1972-
clickBuilder.deeplinkReferrer = [referrer absoluteString];
1973-
}
19741965

19751966
ADJActivityPackage *clickPackage = [clickBuilder buildClickPackage:@"deeplink"];
19761967
[selfI.sdkClickHandler sendSdkClick:clickPackage];

Adjust/Internal/ADJPackageBuilder.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@
2020

2121
@property (nonatomic, copy) NSString * _Nullable deeplink;
2222

23-
@property (nonatomic, copy) NSString * _Nullable deeplinkReferrer;
24-
2523
@property (nonatomic, copy) NSString * _Nullable reftag;
2624

2725
@property (nonatomic, copy) NSDate * _Nullable clickTime;

Adjust/Internal/ADJPackageBuilder.m

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,6 @@ - (NSMutableDictionary *)getClickParameters:(NSString *)source {
604604
[ADJPackageBuilder parameters:parameters setDictionary:self.deeplinkParameters forKey:@"params"];
605605
[ADJPackageBuilder parameters:parameters setDictionary:[self.globalParameters.partnerParameters copy] forKey:@"partner_params"];
606606
[ADJPackageBuilder parameters:parameters setDate:self.purchaseTime forKey:@"purchase_time"];
607-
[ADJPackageBuilder parameters:parameters setString:self.deeplinkReferrer forKey:@"referrer"];
608607
[ADJPackageBuilder parameters:parameters setDate:[ADJUserDefaults getSkadRegisterCallTimestamp] forKey:@"skadn_registered_at"];
609608
[ADJPackageBuilder parameters:parameters setString:source forKey:@"source"];
610609
[ADJPackageBuilder parameters:parameters setDate1970:(double)self.packageParams.startedAt forKey:@"started_at"];

Adjust/Internal/ADJUserDefaults.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,10 @@
3737
+ (void)removeCoppaCompliance;
3838

3939
+ (void)saveDeeplinkUrl:(NSURL *)deeplink
40-
referrerUrl:(NSURL *)referrer
4140
clickTime:(NSDate *)clickTime;
4241

4342
+ (NSURL *)getDeeplinkUrl;
4443

45-
+ (NSURL *)getDeeplinkReferrerUrl;
46-
4744
+ (NSDate *)getDeeplinkClickTime;
4845

4946
+ (void)removeDeeplink;

Adjust/Internal/ADJUserDefaults.m

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,13 @@
1414
static NSString * const PREFS_KEY_INSTALL_TRACKED = @"adj_install_tracked";
1515
static NSString * const PREFS_KEY_COPPA_COMPLIANCE = @"adj_coppa_compliance";
1616
static NSString * const PREFS_KEY_DEEPLINK_URL = @"adj_deeplink_url";
17-
static NSString * const PREFS_KEY_DEEPLINK_REFERRER_URL = @"adj_deeplink_referrer_url";
1817
static NSString * const PREFS_KEY_DEEPLINK_CLICK_TIME = @"adj_deeplink_click_time";
1918
static NSString * const PREFS_KEY_ADSERVICES_TRACKED = @"adj_adservices_tracked";
2019
static NSString * const PREFS_KEY_SKAD_REGISTER_CALL_TIME = @"adj_skad_register_call_time";
2120
static NSString * const PREFS_KEY_LINK_ME_CHECKED = @"adj_link_me_checked";
2221
static NSString * const PREFS_KEY_DEEPLINK_URL_CACHED = @"adj_deeplink_url_cached";
2322
static NSString * const PREFS_KEY_ATT_WAITING_REMAINING_SECONDS = @"adj_att_waiting_remaining_seconds";
2423
static NSString * const PREFS_KEY_CONTROL_PARAMS = @"adj_control_params";
25-
static NSString * const PREFS_KEY_DEEPLINK_REFERRER_URL_CACHED = @"adj_deeplink_referrer_url_cached";
2624

2725
@implementation ADJUserDefaults
2826

@@ -83,28 +81,21 @@ + (void)removeCoppaCompliance {
8381
}
8482

8583
+ (void)saveDeeplinkUrl:(NSURL *)deeplink
86-
referrerUrl:(NSURL *)referrer
8784
clickTime:(NSDate *)clickTime {
8885
[[NSUserDefaults standardUserDefaults] setURL:deeplink forKey:PREFS_KEY_DEEPLINK_URL];
89-
[[NSUserDefaults standardUserDefaults] setURL:referrer forKey:PREFS_KEY_DEEPLINK_REFERRER_URL];
9086
[[NSUserDefaults standardUserDefaults] setObject:clickTime forKey:PREFS_KEY_DEEPLINK_CLICK_TIME];
9187
}
9288

9389
+ (NSURL *)getDeeplinkUrl {
9490
return [[NSUserDefaults standardUserDefaults] URLForKey:PREFS_KEY_DEEPLINK_URL];
9591
}
9692

97-
+ (NSURL *)getDeeplinkReferrerUrl {
98-
return [[NSUserDefaults standardUserDefaults] URLForKey:PREFS_KEY_DEEPLINK_REFERRER_URL];
99-
}
100-
10193
+ (NSDate *)getDeeplinkClickTime {
10294
return [[NSUserDefaults standardUserDefaults] objectForKey:PREFS_KEY_DEEPLINK_CLICK_TIME];
10395
}
10496

10597
+ (void)removeDeeplink {
10698
[[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_DEEPLINK_URL];
107-
[[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_DEEPLINK_REFERRER_URL];
10899
[[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_DEEPLINK_CLICK_TIME];
109100
}
110101

@@ -173,7 +164,6 @@ + (void)clearAdjustStuff {
173164
[[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_COPPA_COMPLIANCE];
174165
[[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_GDPR_FORGET_ME];
175166
[[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_DEEPLINK_URL];
176-
[[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_DEEPLINK_REFERRER_URL];
177167
[[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_DEEPLINK_CLICK_TIME];
178168
[[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_ADSERVICES_TRACKED];
179169
[[NSUserDefaults standardUserDefaults] removeObjectForKey:PREFS_KEY_SKAD_REGISTER_CALL_TIME];

AdjustTests/AdjustTestApp/AdjustTestApp/ATAAdjustCommandExecutor.m

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -580,12 +580,8 @@ - (void)setPushToken:(NSDictionary *)parameters {
580580

581581
- (void)openDeeplink:(NSDictionary *)parameters {
582582
NSString *deeplinkS = [parameters objectForKey:@"deeplink"][0];
583-
NSString *referrerS = [parameters objectForKey:@"referrer"][0];
584583
NSURL *deeplink = [NSURL URLWithString:deeplinkS];
585-
NSURL *referrer = [NSURL URLWithString:referrerS];
586-
ADJDeeplink *adjustDeeplink = [[ADJDeeplink alloc] initWithDeeplink:deeplink];
587-
adjustDeeplink.referrer = referrer;
588-
[Adjust processDeeplink:adjustDeeplink];
584+
[Adjust processDeeplink:[[ADJDeeplink alloc] initWithDeeplink:deeplink]];
589585
}
590586

591587
- (void)gdprForgetMe:(NSDictionary *)parameters {

0 commit comments

Comments
 (0)