Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept style as cli arg #128

Closed
wants to merge 13 commits into from
Closed

Accept style as cli arg #128

wants to merge 13 commits into from

Conversation

airtonix
Copy link

fixes #127

@airtonix airtonix changed the title Patch 2 Accept style as cli arg Dec 10, 2022
Copy link

@heliomar-pena heliomar-pena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add a little explanation about how to use your changes?

@julian-poidevin
Copy link

@airtonix Could you add documentation ?

@julian-poidevin
Copy link

@victor-heliomar I also could form from @airtonix branch, and add the required documentation, I'm really interested on that feature.

@heliomar-pena
Copy link

@julian-poidevin maybe create another PR with the doc and I think this could be merged

Seems like in issue #127 description is a way to use it, only needs to be tested
image

What do you think?

@julian-poidevin
Copy link

@julian-poidevin maybe create another PR with the doc and I think this could be merged

Seems like in issue #127 description is a way to use it, only needs to be tested image

What do you think?

On my fork, I merged this PR and it's working as expected.
I'll create a branch of @airtonix branch to add documentation on how to use the cli and open a new PR here.
I hope @airtonix doesn't mind.

@airtonix airtonix closed this by deleting the head repository Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accept style as cli arg to launch.sh
3 participants