Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add Support for Gradient Checkpointing #759

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lenglaender
Copy link
Member

Add Support for Gradient Checkpointing

This PR adds support for gradient checkpointing Gradient checkpointing is a technique that trades computation for memory by recomputing intermediate activations during the backward pass instead of storing them. This is particularly useful when training large models. Because we recompute values during the backpropagation, we need to preserve the original ForwardContext in this phase. I solved this by overwriting the gradient_checkpointing_enable function so that the checkpoint function receives the current ForwardContext as the backward pass context manager.

I added tests to check if it works for every model using 1) a single adapter or 2) parallel composition.

Not Yet Fixed Bugs

  • Single adapter tests: For some models like BERT, the implementation doesn't work. We get an error saying one of the variables needed for gradient computation has been modified by an inplace operation. I couldn't find out where this happened. For some models, the single adapter tests run through (like for Llama, ViT, Whisper); for others not (like BERT, DistilBERT, GPT2).
    • E.g., this test works: pytest tests/test_llama.py::LlamaAdapterTest::test_prefix_tuning_gradient_checkpointing_single_adapter
    • and this does not work: pytest tests/test_bert.py::BertAdapterTest::test_prefix_tuning_gradient_checkpointing_single_adapter
  • For Parallel composition, we get errors with the dimensions. I believe this is due to us changing the batch size. I have not yet had time to take a look at this.
    • E.g. this test doesn't work: pytest tests/test_llama.py::LlamaAdapterTest::test_lora_gradient_checkpointing_parallel_adapters

- oerwrite the gradient_checkpointing_enable to provide our ForwardContext during the recomputation of values during backpropagation
- 2 bugs remaining: bottleneck adapter for models with the legacy implementation (BERT) & Parallel. Parallel has the problem that we manipulate the batch dimension and this currently leads to an error
akatief added a commit to akatief/adapters that referenced this pull request Nov 11, 2024
@calpt calpt force-pushed the fix/gradient_checkpointing branch from 5edfd4d to 94df2fe Compare November 25, 2024 22:09
@calpt calpt linked an issue Dec 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ForwardContext is None with gradient checkpointing enabled
2 participants