4.8.33 (#101)

 * build-231
 * 4.8.33 merge (#94)
 * internal tools front-ends, externalized (#78)
      o mcedit
      o mcdiff and mcbsddiff (diff backend)
      o mcview
 * upgrades/bugfixes
      o pcre2 10.45 (#106)
      o appupdater (#102)
      o glib 2.54.3 (#102)
      o zlib-1.3.1 (#102)
      o mbedtls-3.6.2 (#100)
      o improved UNC and extended prefix support, plus stat optimisations (#98)
      o libssh2-1.11.1 (#95)
      o enhanced utf8 support, directory plus username; non-ascii user name support (#97)
      o EXDEV, cross-device detection rename failure; allowing alt move logic (#85)
      o x64 installer path (#79)

Author: adamyg

.github/workflows/build.yml

@@ -104,7 +104,6 @@ jobs:
         path: mcwin32/bin.${{ matrix.config.toolversion }}/release/*
 
     - name: Installer
-      if: startsWith(matrix.config.name, 'Windows Latest MSVC') || startsWith(matrix.config.name, 'Windows Latest OWC')
       shell: cmd
       run: |
         @set PERL=c:/Strawberry/perl/bin/perl
@@ -114,7 +113,6 @@ jobs:
         "%programfiles(x86)%\Inno Setup 5\ISCC" -DBUILD_INFO=1 -DBUILD_TYPE=release ".\releases\mc-inno-setup.iss"
 
     - name: Release artifacts
-      if: startsWith(matrix.config.name, 'Windows Latest MSVC') || startsWith(matrix.config.name, 'Windows Latest OWC')
       uses: softprops/action-gh-release@v1
       with:
         files: ./mcwin32/releases/mcwin32-build*-setup.exe

.gitignore

@@ -5,6 +5,7 @@ mcmerge/
 busybox/
 mcwin32/bin/
 inno/
+ref/
 directory.txt
 gtk-source.txt
 mcgtk-source.txt

mcsrc/.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,9 @@
+Thank you for thinking about contributing to Midnight Commander, but we **ARE NOT** using pull requests to manage incoming patches!
+
+Instead, please check out our Trac instance to see if the issue has already been reported, or submit a new ticket:
+
+https://midnight-commander.org/wiki/NewTicket
+
+If you chose to submit the pull request instead, keep in mind that we are not checking on them regularly, so it might take ages before we even get to it, if at all.
+
+Unfortunately, GitHub does not allow us to disable the pull requests feature for this repository, so we have to warn you this way...

mcsrc/.github/workflows/ci-alpine.yml

@@ -0,0 +1,46 @@
+name: ci-alpine
+
+on:
+  workflow_call:
+
+jobs:
+  build-alpine:
+    runs-on: ubuntu-latest
+    container:
+      image: alpine:latest
+    timeout-minutes: 5
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install dependencies
+        run: |
+          apk add autoconf automake build-base libtool pkgconf sudo
+          apk add aspell-dev check-dev e2fsprogs-dev gettext-dev glib-dev gpm-dev libssh2-dev perl slang-dev
+
+      - name: Bootstrap build system
+        run: ./autogen.sh
+
+      - name: Build default configuration
+        run: |
+          adduser --home "$(pwd)" --no-create-home --disabled-password test
+          chown -R test "$(pwd)"
+
+          su - test -c ' \
+            ./configure \
+              --prefix="$(pwd)/install-prefix" \
+              --enable-mclib \
+              --enable-aspell \
+              --enable-werror \
+              && \
+            \
+            make -j$(nproc) && \
+            make check  && \
+            make install \
+          '
+
+      - uses: actions/upload-artifact@v4
+        if: failure()
+        with:
+          name: test-suite-logs-alpine
+          path: ./**/test-suite.log

mcsrc/.github/workflows/ci-fedora.yml

@@ -0,0 +1,53 @@
+name: ci-fedora
+
+on:
+  workflow_call:
+
+jobs:
+  build-fedora:
+    runs-on: ubuntu-latest
+    container:
+      image: fedora:latest
+    timeout-minutes: 5
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install dependencies
+        run: |
+          dnf install -y autoconf automake gcc gettext-devel groff libtool make pkgconfig
+          dnf install -y aspell-devel check-devel gpm-devel libX11-devel "pkgconfig(ext2fs)" "pkgconfig(glib-2.0)" "pkgconfig(gmodule-2.0)" "pkgconfig(libssh2)" "pkgconfig(slang)"
+
+          # For tests
+          dnf install -y glibc-gconv-extra util-linux
+
+      - name: Lint documentation
+        working-directory: maint
+        run: ./doctest
+
+      - name: Bootstrap build system
+        run: ./autogen.sh
+
+      - name: Build default configuration
+        run: |
+          useradd --home "$(pwd)" test
+          chown -R test "$(pwd)"
+
+          su - test -c ' \
+            ./configure \
+              --prefix="$(pwd)/install-prefix" \
+              --enable-mclib \
+              --enable-aspell \
+              --enable-werror \
+              && \
+            \
+            make -j$(nproc) && \
+            make check && \
+            make install \
+          '
+
+      - uses: actions/upload-artifact@v4
+        if: failure()
+        with:
+          name: test-suite-logs-fedora
+          path: ./**/test-suite.log

mcsrc/.github/workflows/ci-freebsd.yml

@@ -0,0 +1,54 @@
+name: ci-freebsd
+
+on:
+  workflow_call:
+    inputs:
+      CFLAGS:
+        description: 'Custom CFLAGS'
+        default: ''
+        required: false
+        type: string
+
+jobs:
+  build-freebsd:
+    runs-on: ubuntu-latest
+    timeout-minutes: 15
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Build on FreeBSD
+        uses: vmactions/freebsd-vm@v1
+        with:
+          prepare: |
+            pkg install -y autoconf automake gettext libtool pkgconf
+            pkg install -y aspell check glib libssh2 libX11 python3
+
+          run: |
+            ./autogen.sh
+
+            pw useradd test -d "$(pwd)"
+            chown -R test $(pwd)
+
+            su - test -c ' \
+              \
+              export CFLAGS="${{ inputs.CFLAGS }}" && \
+              \
+              ./configure \
+                --prefix="$(pwd)/install-prefix" \
+                --with-screen=ncurses \
+                --enable-mclib \
+                --enable-aspell \
+                --enable-werror \
+                && \
+              \
+              make && \
+              make check && \
+              make install \
+            '
+
+      - uses: actions/upload-artifact@v4
+        if: failure()
+        with:
+          name: test-suite-logs-freebsd
+          path: ./**/test-suite.log

mcsrc/.github/workflows/ci-macos.yml

@@ -0,0 +1,47 @@
+name: ci-macos
+
+on:
+  workflow_call:
+    inputs:
+      CFLAGS:
+        description: 'Custom CFLAGS'
+        default: ''
+        required: false
+        type: string
+
+jobs:
+  build-macos:
+    runs-on: macos-latest
+    timeout-minutes: 5
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install dependencies
+        run: |
+          brew install autoconf automake gettext check gnu-indent libtool pkg-config
+          brew install aspell e2fsprogs glib libssh2 openssl s-lang
+
+          # unzip is part of the base system
+
+      - name: Bootstrap build system
+        run: ./autogen.sh
+
+      - name: Build default configuration
+        run: |
+          export CFLAGS="${{ inputs.CFLAGS }}"
+
+          ./configure \
+            --prefix="$(pwd)/install-prefix" \
+            --enable-mclib \
+            --enable-aspell=/opt/homebrew
+
+          make -j$(sysctl -n hw.logicalcpu)
+          make check
+          make install
+
+      - uses: actions/upload-artifact@v4
+        if: failure()
+        with:
+          name: test-suite-logs-macos
+          path: ./**/test-suite.log

mcsrc/.github/workflows/ci-solaris.yml

@@ -0,0 +1,48 @@
+name: ci-solaris
+
+on:
+  workflow_call:
+
+jobs:
+  build-solaris:
+    runs-on: ubuntu-latest
+    timeout-minutes: 15
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Build on Solaris
+        uses: vmactions/solaris-vm@v1
+        with:
+          release: "11.4-gcc"  # autoconf automake developer/gcc/gcc-c libtool pkg-config
+          prepare: |
+            pkg install --no-backup-be --no-refresh --accept -v \
+              aspell check glib2 libssh2 libx11
+
+          run: |
+            ./autogen.sh
+
+            useradd -d "$(pwd)" test
+            chown -R test $(pwd)
+
+            su - test -c ' \
+              export PKG_CONFIG_PATH=/usr/lib/64/pkgconfig && \
+              \
+              ./configure \
+                --prefix="$(pwd)/install-prefix" \
+                --with-screen=ncurses \
+                --enable-mclib \
+                --enable-aspell \
+                --enable-werror \
+                && \
+              \
+              make && \
+              make check && \
+              make install \
+            '
+
+      - uses: actions/upload-artifact@v4
+        if: failure()
+        with:
+          name: test-suite-logs-solaris
+          path: ./**/test-suite.log

mcsrc/.github/workflows/ci-ubuntu.yml

@@ -0,0 +1,100 @@
+name: ci-ubuntu
+
+on:
+  workflow_call:
+
+jobs:
+  build-ubuntu:
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install dependencies
+        run: |
+          sudo apt-get install -y autoconf autopoint check gettext indent libtool pkg-config
+          sudo apt-get install -y e2fslibs-dev libaspell-dev libglib2.0-dev libgpm-dev libncurses5-dev libpcre2-dev libslang2-dev libssh2-1-dev libx11-dev unzip
+
+      - name: Bootstrap build system
+        run: ./autogen.sh
+
+      - name: Build distribution archive
+        run: |
+          mkdir -p build-distrib && cd $_
+
+          ../configure
+
+          make dist-bzip2
+
+      - name: Build full configuration
+        run: |
+          tar -xjf $(ls build-distrib/mc-*.tar.bz2) --one-top-level=build-full
+          cd build-full
+
+          ../configure \
+              --prefix="$(pwd)/install" \
+              --enable-mclib \
+              --enable-aspell \
+              --enable-vfs-undelfs \
+              --enable-werror
+
+          make indent
+          # TODO: exit 1
+          git ls-files --modified
+
+          make -j$(nproc)
+          make check
+          make install
+
+      - name: Build ncurses & pcre2 configuration
+        run: |
+          tar -xjf $(ls build-distrib/mc-*.tar.bz2) --one-top-level=build-ncurses
+          cd build-ncurses
+
+          ../configure \
+              --prefix="$(pwd)/install" \
+              --with-screen=ncurses \
+              --with-search-engine=pcre2 \
+              --enable-werror
+
+          make -j$(nproc)
+          make check
+
+      - name: Build minimal configuration
+        run: |
+          tar -xjf $(ls build-distrib/mc-*.tar.bz2) --one-top-level=build-minimal
+          cd build-minimal
+
+          ../configure \
+              --prefix="$(pwd)/install" \
+              --disable-shared \
+              --disable-static \
+              --disable-maintainer-mode \
+              --disable-largefile \
+              --disable-nls \
+              --disable-rpath \
+              --disable-charset \
+              --disable-mclib \
+              --disable-assert \
+              --disable-aspell \
+              --disable-background \
+              --disable-vfs \
+              --disable-doxygen-doc \
+              --without-x \
+              --without-gpm-mouse \
+              --without-internal-edit \
+              --without-diff-viewer \
+              --without-subshell \
+              --enable-tests \
+              --enable-werror
+
+            make -j$(nproc)
+            make check
+
+      - uses: actions/upload-artifact@v4
+        if: failure()
+        with:
+          name: test-suite-logs-ubuntu
+          path: build-*/**/test-suite.log
+