Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex in to #166

Closed
kshitijkurandwad211 opened this issue Jul 26, 2023 · 2 comments
Closed

Regex in to #166

kshitijkurandwad211 opened this issue Jul 26, 2023 · 2 comments

Comments

@kshitijkurandwad211
Copy link

Can add a new feature where right now from can be regex and to is supposed to string.
This is causing problems while using typescript but in normal node js. This works wonderfully. Just changing .d.ts can even run regex for replacement.

@adamreisnz
Copy link
Owner

If this is just a Typescript definitions change, then please feel free to create a PR for this and I'll merge it in.

@adamreisnz
Copy link
Owner

PR has been closed as according to the documentation, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace, the replace function only accepts a string or a function, not a regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants