Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and restore writable attributes as well #18

Open
tannewt opened this issue Oct 17, 2024 · 0 comments
Open

Save and restore writable attributes as well #18

tannewt opened this issue Oct 17, 2024 · 0 comments

Comments

@tannewt
Copy link
Member

tannewt commented Oct 17, 2024

From @Apollon77 on #7:

How did you decided if an attribute is non volatile? If you just use the spec flagging you might not have all needed ones.

Matter.js uses the best practice: When an attribute is writable OR non-volatiove then we persist it. For some writable attributes the Non-volatile flagging is missing but in fact if these are config then it only makes sense to also persist them- Spec is a bit vague here because it states that non-volatile should be persisted or "when needed" :-)

So maybe you should think to also include writable ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant