Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add warmbit_bluepixel #217

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add warmbit_bluepixel #217

wants to merge 1 commit into from
+90 −0

Conversation

warmbit
Copy link

@warmbit warmbit commented Aug 25, 2021

This is for my prototype board. Temporarily I am using Nordic's VID and random PID.

hathach
hathach requested changes Aug 26, 2021
View reviewed changes
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes looks good, but you really need to have a designated VID/PID for me to merge the PR, an random PID could have conflict with other commercial product from nordic

@hathach hathach marked this pull request as draft September 15, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@warmbit @hathach