Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adafruit_MQTT.cpp:264:46: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] #182

Open
flavio-fernandes opened this issue Sep 12, 2020 · 1 comment · May be fixed by #187
Open

Adafruit_MQTT.cpp:264:46: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] #182

flavio-fernandes opened this issue Sep 12, 2020 · 1 comment · May be fixed by #187

Comments

@flavio-fernandes
Copy link
Contributor

flavio-fernandes commented Sep 12, 2020 •
edited
Loading

  • Arduino board:

ESP8266

platform = espressif8266
board = esp12e
framework = arduino
  • Arduino IDE version (found in Arduino -> About Arduino menu):
PlatformIO, version 4.3.4
Using Adafruit MQTT Library version 1.3.0
  • List the steps to reproduce the problem below (if possible attach a sketch or
    copy the sketch code in too):

Using platform.io, compile project that uses Adafruit_MQTT_Library

...
Compiling .pio/build/esp12e/lib2f0/ESP8266WiFi/BearSSLHelpers.cpp.o
/Users/ff/.platformio/lib/Adafruit MQTT Library/Adafruit_MQTT.cpp: In member function 'uint16_t Adafruit_MQTT::readFullPacket(uint8_t*, uint16_t, uint16_t)':
/Users/ff/.platformio/lib/Adafruit MQTT Library/Adafruit_MQTT.cpp:264:46: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (value > (maxsize - (pbuff - buffer) - 1)) {
                                              ^
Archiving .pio/build/esp12e/lib16c/libAdafruit Unified Sensor.a
...

Reference project where I see this: https://github.com/flavio-fernandes/iotMqttAttic
@mpoettgen mpoettgen linked a pull request Feb 15, 2021 that will close this issue
Open
@mpoettgen
Copy link

Same problem here. Created a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change readFullPacket mpoettgen/Adafruit_MQTT_Library
2 participants
@flavio-fernandes @mpoettgen