Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Adafruit_MCP9600.cpp #12

Open
ShaoVN opened this issue Jul 16, 2024 · 0 comments
Open

Typo in Adafruit_MCP9600.cpp #12

ShaoVN opened this issue Jul 16, 2024 · 0 comments

Comments

@ShaoVN
Copy link

ShaoVN commented Jul 16, 2024

Howdy all,
I am currently tinkering with some MCP9601's and was looking around the library and found a typo. specifically on lines 206-224. Basically instead of "thermocouple" some names contain "themocouple" however it doesnt seem to have a performance issue and everything works fine (I assume Kevin just rolled with the spelling lol) I just figured I should bring it up.

Specific Example

Adafruit_MCP9600.cpp lines 206-213

MCP9600_ThemocoupleType Adafruit_MCP9600::getThermocoupleType(void) {
  // define the register
  Adafruit_I2CRegister sensorconfig =
      Adafruit_I2CRegister(i2c_dev, MCP9600_SENSORCONFIG, 1, MSBFIRST);
  Adafruit_I2CRegisterBits type =
      Adafruit_I2CRegisterBits(&sensorconfig, 3, 4); // # bits, bit_shift

  return (MCP9600_ThemocoupleType)type.read();
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant