New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong logic for initializing _err_sub and _throttle_sub #113

Open

kintel opened this issue Apr 3, 2020 · 0 comments

Contributor

kintel commented Apr 3, 2020

See this code fragment:

Adafruit_IO_Arduino/src/AdafruitIO.cpp

Lines 154 to 159 in e2b69fd

    
           if (_err_sub) { 
        
             // setup error sub 
        
             _err_sub = new Adafruit_MQTT_Subscribe(_mqtt, _err_topic); 
        
             _mqtt->subscribe(_err_sub); 
        
             _err_sub->setCallback(errorCallback); 
        
           }

_err_sub is only initialized if it's non-NULL, which is the opposite of what I'd expect.
Same for _throttle_sub.

As an aside, this will never actually be executed, as both are initialized to 0.
It doesn't look like this is the intended behavior of this code.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment