adding get_functions #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, |
|
@EuropaSteve This PR was never merged, as I think you see. @jposada202020 Do you remember why you closed this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27
For the reviewer:
There are two changes here
__init__the callself.initializate()there was calling theEMC2101_LUTinitialization and not theEMC2101one. I guess that is why they were using thesuper().initializationline.. But who knows. This solves the issue when the line below was change toTrueAdafruit_CircuitPython_EMC2101/adafruit_emc2101/emc2101_ext.py
Line 135 in aea77f5
I have test with the three examples, be aware that, that I could not test the outside_temperature as I do not how to wire it... I did test with a fan. I use a mock up temperature for the tests. No other changes were made, this PR is solely to solve the issue and no to look further in Library problems
@brody please could you test, thanks :) Hope you have at least a start on how to change the library. Good Luck