Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for Matchers #59

Open
adaamko opened this issue May 20, 2022 · 2 comments
Open

Tests for Matchers #59

adaamko opened this issue May 20, 2022 · 2 comments
Assignees
@recski @Eszti @GKingA @adaamko
Labels
enhancement New feature or request

Comments

@adaamko
Copy link
Owner

adaamko commented May 20, 2022 •
edited
Loading

I think it would be great if there were test cases for matchers now as we begin to support lot of things now. In the test folder there are some tests now for rules, we could add more there, especially when we introduce new mechanisms.

Thoughts?
@adaamko adaamko added the enhancement New feature or request label May 20, 2022
@adaamko
Copy link
Owner Author

adaamko commented May 20, 2022 •
edited
Loading

Also some small sample rules/sentences for our use-cases (e.g. BRISE, Hatespeech). Especially since we want to introduce a new Graph class and these tests would make the conversion much easier.

@Eszti
Copy link
Collaborator

Eszti commented May 20, 2022

Love both ideas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@recski recski

@Eszti Eszti

@GKingA GKingA

@adaamko adaamko

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@recski @Eszti @GKingA @adaamko