Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actix-files: Publicly re-export new_chunked_read #3514

Open
gshep opened this issue Dec 6, 2024 · 0 comments
Open

actix-files: Publicly re-export new_chunked_read #3514

gshep opened this issue Dec 6, 2024 · 0 comments

Comments

@gshep
Copy link

gshep commented Dec 6, 2024

Hi!

I searched through the task list and didn't seem to find one.

The library re-exports the ChunkedReadFile structure, but it is impossible to create it from the outside, since the function scope is declared only for the library. This struct can be useful when implementing custom logic for streaming files, so I suggest re-exporting it as well.

Expected Behavior

new_chunked_read should be marked as pub and re-exported by the crate.

Current Behavior

new_chunked_read is marked as pub(crate) - https://github.com/actix/actix-web/blob/web-v4.9.0/actix-files/src/chunked.rs#L56

  • Actix Files 0.6.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant