Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(google-forms): add support for Google Team drives #4667

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(google-forms): add support for Google Team drives #4667

wants to merge 2 commits into from
+14 −4

Conversation

Startouf
Copy link

@Startouf Startouf commented May 11, 2024 •
edited by abuaboud

Replicate code from google sheets so Google Forms can be used with Team Drives
using API ref from https://developers.google.com/drive/api/reference/rest/v3/files/list

What does this PR do?

Fixes #4666
Related to #4665

ANNOUNCEMENT=true

@CLAassistant
Copy link

CLAassistant commented May 11, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@Startouf Startouf force-pushed the feature/support-team-drives-google-form branch from 62e74cd to 755e187 Compare May 11, 2024 11:16
@Startouf Startouf force-pushed the feature/support-team-drives-google-form branch from 755e187 to a1fd1d0 Compare May 11, 2024 11:18
@Startouf Startouf changed the title feat: add support for Google Team drives feat(google-forms): add support for Google Team drives May 11, 2024
@abuaboud
Copy link
Contributor

@allcontributors please add @Startouf for plugin

@allcontributors allcontributors bot mentioned this pull request May 13, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@abuaboud

I've put up a pull request to add @Startouf! 🎉

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 13, 2024 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 24ad6b6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx affected --target=build -c production --parallel=3
✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@Startouf
Copy link
Author

Hmm the failing test is weird.

> nx run pieces-google-forms:build 

Compiling TypeScript files for project "pieces-google-forms"...
packages/pieces/community/google-forms/src/lib/common/common.ts:36:15 - error TS2322: Type 'unknown' is not assignable to type 'string'.

36               includeItemsFromAllDrives: include_team_drives,
                 ~~~~~~~~~~~~~~~~~~~~~~~~~

On the google drive API the query param exists. Will investigate where the types come from

Screenshot 2024-05-14 at 20 27 55

@kishanprmr
Copy link
Collaborator

Hello @Startouf , Please add following line of code for team drives variable in query params.

includeItemsFromAllDrives: include_team_drives ? 'true' : 'false',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abuaboud abuaboud abuaboud left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🔌 pieces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Forms can be fetched from Team Drives
4 participants
@Startouf @CLAassistant @abuaboud @kishanprmr