Skip to content

Commit f4d748d

Browse files
unguiculusk8s-ci-robot
authored andcommitted
Update pull request template (helm#4087)
* Wrap general directions into an HTML comment so they are not visible in the PR if the user doesn't delete them * Add template for information a user is supposed to provide in order to avoid getting empty descriptions * Add note on CircleCI
1 parent ae2a474 commit f4d748d

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
*****************************************************************************************
2-
1+
<!--
32
Thank you for contributing to kubernetes/charts. Before you submit this PR we'd like to
43
make sure you are aware of our technical requirements and best practices:
54
@@ -14,8 +13,20 @@ our review guidelines:
1413
Following our best practices right from the start will accelerate the review process and
1514
help get your PR merged quicker.
1615
17-
When updates to your PR are requested, please add new commits and do not squash the
18-
history. This will make it easier to identify new changes. The PR will be squashed
16+
When updates to your PR are requested, please add new commits and do not squash the
17+
history. This will make it easier to identify new changes. The PR will be squashed
1918
anyways when it is merged. Thanks.
2019
21-
*****************************************************************************************
20+
For fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.
21+
22+
Please make sure you test your changes before you push them. Once pushed, a CircleCI
23+
will run across your changes and do some initial checks and linting. These checks run
24+
very quickly. Please check the results. We would like these checks to pass before we
25+
even continue reviewing your changes.
26+
-->
27+
28+
**What this PR does / why we need it**:
29+
30+
**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
31+
32+
**Special notes for your reviewer**:

0 commit comments

Comments
 (0)