-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add accessible names for navigation buttons #8338
base: master
Are you sure you want to change the base?
[WIP] Add accessible names for navigation buttons #8338
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8338 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 140 140
Lines 4018 4018
=======================================
Hits 3982 3982
Misses 36 36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with either. Is the aria-label
the recommended approach? If so, then we should use that.
If we label these buttons, wouldn't we need to label others like the main navigation?
The upgrading guide should also be updated to include the new locale keys.
That's a good question. I'm not sure
That's correct. Since that button is not visible in large desktop, it was not spotted by lighthouse
Will do that |
I'm still not sure on how to work on this feature I have concerns related to:
I will clarify in the future |
What characters need to be escaped? I don't see anything in the changes here that is out of the ordinary. |
6eb2d10
to
72fe6d1
Compare
I've seen both sets of terms used. Vitepress uses |
72fe6d1
to
2d74d08
Compare
- Remove reference to `drawer-navigation-label`, which is not defined - Change `aria-controls` to `main-menu` - Add `aria-label` to buttons without text Close activeadmin#8328
2d74d08
to
6cf4ace
Compare
drawer-navigation-label
, which is not definedaria-controls
tomain-menu
aria-label
to buttons without textClose #8328