-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: "pip"
cache having nothing installed leads to post-run error
#815
Comments
Okay, I figured it out, the issue was not
Thus the conclusion is, if
|
"pip"
cache having nothing installed leads to post-run error
Hello @jamesbraza |
Hi @jamesbraza 👋 , Thank you for sharing your experience and suggestions! |
Usually an issue stays open until it's resolved, not closed as completed when it wasn't. Think of issues as targets to aim for, but closing them defeats that |
This was prompted by a bug in setup-python@v5, which means that the post-clean-up job will fail if you do not actually install anything in pip, as the cache directory will not be created. This has hit a few of our GHA workflows. actions/setup-python#815 The reason this was triggering for job-runner was that the current CI setup was pretty much broken. Firstly, the PYTHON_VERSION env var was not being set, which meant that every test run was always testing 3.8, not 3.9 or 3.10 as per the matrix. Fixing this meant a bit of windows/powershell finesse. It always explains the fact that for some reason, even though we have 22.04 in the matrix, we did not run the tests on it (this was what triggered the above failure). Additionally, we were going to the trouble of installing/starting docker on macos, and then not even running the docker tests. This feels like we had the abandonded attempts of getting docker tests running on macos. To fix this, I just removed those steps and fully embraced not running docker tests (which required excluding a few more tests). Additionally, macos-12 is old, and has very slow runners, so I took the opportunity to update to using macos-13. I did attempt to use our opensafely-core/setup-action, but it still seems to have problems with just on windows, and my yak stack was full.
This was prompted by a bug in setup-python@v5, which means that the post-clean-up job will fail if you do not actually install anything in pip, as the cache directory will not be created. This has hit a few of our GHA workflows. actions/setup-python#815 The reason this was triggering for job-runner was that the current CI setup was pretty much broken. Firstly, the PYTHON_VERSION env var was not being set, which meant that every test run was always testing 3.8, not 3.9 or 3.10 as per the matrix. Fixing this meant a bit of windows/powershell finesse. It always explains the fact that for some reason, even though we have 22.04 in the matrix, we did not run the tests on it (this was what triggered the above failure). Additionally, we were going to the trouble of installing/starting docker on macos, and then not even running the docker tests. This feels like we had the abandonded attempts of getting docker tests running on macos. To fix this, I just removed those steps and fully embraced not running docker tests (which required excluding a few more tests). Additionally, macos-12 is old, and has very slow runners, so I took the opportunity to update to using macos-13. I did attempt to use our opensafely-core/setup-action, but it still seems to have problems with just on windows, and my yak stack was full.
Description:
I have this:
Bumping
python-version
from'3.10'
to'3.12'
, I am now getting this error during Post Run actions/setup-python@5:Action version:
v5
Platform:
Runner type:
Tools version:
3.10.13 to 3.12.1
Expected behavior:
I expect
setup-python
to somehow not error itself.Seemingly related issues:
Actual behavior:
Here is the output of
Run actions/setup-python@v5
Here is the output of
Post Run actions/setup-python@5
:The text was updated successfully, but these errors were encountered: